checkers: add builtinShadowDecl #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd07b28 to
dd98420
Compare
cristaloleg
previously approved these changes
Sep 12, 2020
| @@ -0,0 +1,21 @@ | |||
| package checker_test | |||
There was a problem hiding this comment.
Can you add type int = struct{} too?
Finds top-level symbols that have a name that will shadow a builtin identifier for the entire package. Unlike builtinShadow, it's not a style but rather a diganostic check. Fixes #868 Signed-off-by: Iskander Sharipov <[email protected]>
dd98420 to
1afc947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds top-level symbols that have a name that will shadow a
builtin identifier for the entire package.
Unlike builtinShadow, it's not a style but rather a diganostic check.
Fixes #868
Signed-off-by: Iskander Sharipov [email protected]