checkers: add badLock checker #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa04fd4 to
4a14a7c
Compare
cristaloleg
previously approved these changes
Oct 16, 2020
Finds mismatching Lock+Unlock sequences. Lock+RUnlock -> error RLock+Unlock -> error Lock+Unlock -> OK RLock+RUnlock -> OK It only checks the 2 adjusted statements. We don't check for types being sync.Mutex or sync.RWMutex, let's see how bad it will be for a false positive rates. People could embed locks or implement custom Lock+Unlock methods. We won't mark this checker as stable until it's properly tested, so it shouldn't be a deal breaker. Signed-off-by: Iskander Sharipov <[email protected]>
4a14a7c to
f893f1b
Compare
cristaloleg
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds mismatching Lock+Unlock sequences.
It only checks the 2 adjusted statements.
We don't check for types being sync.Mutex or sync.RWMutex,
let's see how bad it will be for a false positive rates.
People could embed locks or implement custom Lock+Unlock methods.
We won't mark this checker as stable until it's properly tested,
so it shouldn't be a deal breaker.
Signed-off-by: Iskander Sharipov [email protected]