Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Multiple LFS improvements #10667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 5 commits into from
Mar 9, 2020
Merged

Multiple LFS improvements #10667

zeripath merged 5 commits into from
Mar 9, 2020

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 8, 2020

  • Radically increase the logging within the LFS server and prevent the passing of internal error information to clients
  • Handle cursoring in LFS Lock querying.
  • Use a standardised jwt.Claims object rather than passing generic map

Close #10665

zeripath added 3 commits March 8, 2020 11:35
@zeripath
Add more logging in the LFS server
81ed443 
Adds more logging in the LFS server and stops sending internal server
error information to the client

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Add LFS Lock cursor implementation
85425a9 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Simplify Claims in LFS and remove the float64 casts
41535e1 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Mar 8, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 8, 2020
guillep2k
guillep2k reviewed Mar 8, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2020
guillep2k
guillep2k approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2020
@codecov-io
Copy link

codecov-io commented Mar 8, 2020

Codecov Report

Merging #10667 into master will decrease coverage by 0.01%.
The diff coverage is 16.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10667      +/-   ##
==========================================
- Coverage   43.57%   43.56%   -0.02%     
==========================================
  Files         588      588              
  Lines       82490    82587      +97     
==========================================
+ Hits        35949    35982      +33     
- Misses      42087    42134      +47     
- Partials     4454     4471      +17
Impacted Files Coverage Δ
cmd/serv.go 2.8% <0%> (-0.04%) ⬇️
modules/setting/setting.go 44.33% <100%> (+0.26%) ⬆️
modules/lfs/server.go 40.35% <11.94%> (-4.25%) ⬇️
modules/lfs/locks.go 45.91% <22.41%> (-4.69%) ⬇️
modules/lfs/content_store.go 45.33% <7.69%> (-7.8%) ⬇️
modules/notification/indexer/indexer.go 50.66% <0%> (-4%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
models/pull.go 42.85% <0%> (+0.55%) ⬆️
services/pull/pull.go 35.88% <0%> (+0.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8551f8...31365da. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2020
@zeripath zeripath merged commit 9269b7f into go-gitea:master Mar 9, 2020
@zeripath zeripath deleted the lfs-logging-improvements branch March 9, 2020 19:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

git lfs pushed files are empty

5 participants

@zeripath @codecov-io @lafriks @guillep2k @GiteaBot