Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move gocovmerge as vendor #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 3 commits into from
Apr 4, 2020
Merged

Move gocovmerge as vendor #10947

lafriks merged 3 commits into from
Apr 4, 2020

Conversation

@lunny
Copy link
Member

@lunny lunny commented Apr 4, 2020

As title.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 4, 2020
@mrsdizzie mrsdizzie mentioned this pull request Apr 4, 2020
Merged
guillep2k
guillep2k reviewed Apr 4, 2020
View reviewed changes
guillep2k
guillep2k approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit (in a previous comment)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 4, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 4, 2020
@lafriks lafriks merged commit b264c30 into go-gitea:master Apr 4, 2020
@lunny lunny deleted the lunny/vendor_gocovmerge branch April 4, 2020 08:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @lafriks @mrsdizzie @guillep2k @GiteaBot