Codecov Report

Merging #10361 into master will increase coverage by 0.04%.
The diff coverage is 41.33%.

@@            Coverage Diff             @@
##           master   #10361      +/-   ##
==========================================
+ Coverage   43.67%   43.71%   +0.04%     
==========================================
  Files         585      586       +1     
  Lines       81080    81223     +143     
==========================================
+ Hits        35414    35510      +96     
- Misses      41279    41321      +42     
- Partials     4387     4392       +5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13c0b9...6d78baf. Read the comment docs.

@zeripath Could you add a test for this?

@lunny I'd love to if you could tell me an example test to look at...

Check out this for better file/dir reading using src-d: https://github.com/src-d/go-license-detector/blob/63bc9348890a362ea9cc95e78b68c67db2aba656/licensedb/filer/filer.go#L111

So @lafriks I don't think we can do that if we want to continue to allow Readme/README/ReAdMe/etc. we can't just query each individual type so we have to walk the directory structure.

Symbolic links are also supported?

README.md -> my/own/subdirectory/README.md

yes

Awesome. Thanks!