Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add auto-generated serviceworker.js to .gitignore#11567

Closed
CirnoT wants to merge 2 commits intogo-gitea:masterfrom
CirnoT:serviceworker-gitignore
Closed

Add auto-generated serviceworker.js to .gitignore#11567
CirnoT wants to merge 2 commits intogo-gitea:masterfrom
CirnoT:serviceworker-gitignore

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 22, 2020

Since #11538

Needs backport to v1.12

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2020
@silverwind
Copy link
Member

silverwind commented May 23, 2020

Ah, this explains why I did not notice the issue described in #11562 (comment) earlier. It was using the file from the devbuild when I did the prod build. Made sure issues like that can not happen anymore in 376988d.

@silverwind
Copy link
Member

Could you move it one line above? Seems more logical to have the public entries together.

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 23, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 23, 2020

Closed by #11577

@CirnoT CirnoT closed this May 23, 2020
@CirnoT CirnoT deleted the serviceworker-gitignore branch May 23, 2020 14:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments