Move syntax highlighting to web worker#11017
Merged
lafriks merged 2 commits intogo-gitea:masterfrom Apr 13, 2020
Merged
Conversation
3362bae to
9eeb2c7
Compare
Member
Author
|
It might be worth removing |
guillep2k
reviewed
Apr 9, 2020
Member
Author
|
Regarding removal of |
Member
Author
|
Fixed a race condition that happened with multiple outstanding highlight requests by adding a |
Codecov Report
@@ Coverage Diff @@
## master #11017 +/- ##
==========================================
- Coverage 43.43% 43.41% -0.02%
==========================================
Files 597 597
Lines 84628 84628
==========================================
- Hits 36754 36741 -13
- Misses 43344 43352 +8
- Partials 4530 4535 +5
Continue to review full report at Codecov.
|
guillep2k
reviewed
Apr 10, 2020
lafriks
approved these changes
Apr 10, 2020
guillep2k
approved these changes
Apr 10, 2020
This should eliminate page freezes when loading big files/diff. `highlightBlock` is needed to preserve existing nodes when highlighting and for that, highlight.js needs access to the DOM API so I added a DOM implementation to make it work, which adds around 300kB to the output file size of the lazy-loaded `highlight.js`.
Member
|
Make lgtm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
This should eliminate page freezes when loading big files/diff. `highlightBlock` is needed to preserve existing nodes when highlighting and for that, highlight.js needs access to the DOM API so I added a DOM implementation to make it work, which adds around 300kB to the output file size of the lazy-loaded `highlight.js`. Co-authored-by: Lauris BH <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should eliminate page freezes when loading big files/diff.
highlightBlockis needed to preserve our existing HTML nodes when highlighting and for that, highlight.js needs access to the DOM API so I added a DOM implementation to make it work, which adds around 300kB to the output file size of the lazy-loadedhighlight.jschunk.