Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ignored login on compare #12476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sapk merged 1 commit into from
Aug 12, 2020
Merged

Fix ignored login on compare #12476

sapk merged 1 commit into from
Aug 12, 2020

Conversation

@lunny
Copy link
Member

@lunny lunny commented Aug 12, 2020

As title

@lunny lunny added this to the 1.13.0 milestone Aug 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #12476 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12476      +/-   ##
==========================================
+ Coverage   43.79%   43.81%   +0.01%     
==========================================
  Files         631      631              
  Lines       69851    69851              
==========================================
+ Hits        30589    30602      +13     
+ Misses      34317    34309       -8     
+ Partials     4945     4940       -5
Impacted Files Coverage Δ
routers/routes/routes.go 88.63% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/unit.go 45.07% <0.00%> (-2.82%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
routers/repo/view.go 37.33% <0.00%> (-0.65%) ⬇️
models/issue.go 57.14% <0.00%> (+0.35%) ⬆️
modules/notification/webhook/webhook.go 48.95% <0.00%> (+0.52%) ⬆️
services/pull/pull.go 43.18% <0.00%> (+0.92%) ⬆️
modules/git/repo.go 53.80% <0.00%> (+2.03%) ⬆️
modules/queue/workerpool.go 62.04% <0.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18b052...b0f4550. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 12, 2020
@CirnoT
Copy link
Contributor

CirnoT commented Aug 12, 2020

#11240

@zeripath
Copy link
Contributor

zeripath commented Aug 12, 2020

@CirnoT we should have used ignSignIn in that PR

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 12, 2020
@sapk sapk merged commit 4e1c7cc into go-gitea:master Aug 12, 2020
@sapk
Copy link
Member

sapk commented Aug 12, 2020

@lunny please send backport

@lunny lunny deleted the lunny/fix_compare branch August 12, 2020 12:08
lunny added a commit to lunny/gitea that referenced this pull request Aug 12, 2020
@lunny
Fix ignored login on compare (go-gitea#12476)
e47698b
@techknowlogick techknowlogick mentioned this pull request Aug 12, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Aug 12, 2020
techknowlogick added a commit that referenced this pull request Aug 12, 2020
@techknowlogick @lunny
Fix ignored login on compare (#12476) (#12478)
6d3b814 
Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lunny @codecov-commenter @CirnoT @zeripath @sapk @techknowlogick @GiteaBot