Thanks to visit codestin.com
Credit goes to github.com

Skip to content

misc webpack tweaks #9924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 3 commits into from
Jan 22, 2020
Merged

misc webpack tweaks #9924

lunny merged 3 commits into from
Jan 22, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jan 21, 2020

  • reduce verbosity during build
  • use array form use to allow easier extension
  • disable uninteresting source maps
  • disable symlink resolution for a speedup

Overall this gives about 10% speedup on the webpack build.

@silverwind
misc webpack tweaks
3d7e0d6 
- reduce verbosity during build
- use array form `use` to allow easier extension
- disable uninteresting source maps
- disable symlink resolution for a speedup
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 21, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@43c2ba0). Click here to learn what that means.
The diff coverage is 23.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9924   +/-   ##
=========================================
  Coverage          ?   42.28%           
=========================================
  Files             ?      608           
  Lines             ?    79392           
  Branches          ?        0           
=========================================
  Hits              ?    33570           
  Misses            ?    41679           
  Partials          ?     4143
Impacted Files Coverage Δ
services/pull/commit_status.go 5.19% <0%> (ø)
routers/repo/pull.go 28.67% <0%> (ø)
models/commit_status.go 64.13% <100%> (ø)
routers/api/v1/repo/status.go 44.57% <50%> (ø)
modules/structs/commit_status.go 54.54% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c2ba0...0ed41f9. Read the comment docs.

@lunny lunny merged commit c7fe028 into go-gitea:master Jan 22, 2020
@silverwind silverwind deleted the build-tweaks branch January 22, 2020 11:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@silverwind @codecov-io @techknowlogick @lafriks @lunny @GiteaBot @zeripath