Accept io.Reader for Attach and Embed #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcesaro what can I do to help have this merged? |
This was referenced Dec 6, 2017
jkak
referenced
this pull request
in jkak/mail
May 24, 2018
PR: Accept io.Reader for Attach and Embed go-mail#78 thanks for arbarlow
|
Why are you waiting to merge this? |
ivy
added a commit
to go-mail/mail
that referenced
this pull request
Nov 10, 2018
Accept io.Reader for Attach and Embed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a patch that will accept an
io.Readerfor both Attach and Embed with accompanying tests.I kept the original methods named as
Attachand addedAttachReaderthough it is up for discussion!I feel in Go the idiomatic thing would be to have
and
So that
AttachFileis really only a convenience method. I think most people in Go would be using something io.Reader compatible?But it works for the time being and it's sufficient enough
I wanted to add an example to the example file. But since it's pointing to a gopkg.in version that couldn't be possible at the moment without breaking the test suite.
This is talked about in issue #69