Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not panic if Begin().Error was ignored (#1830) #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2018
Merged

Do not panic if Begin().Error was ignored (#1830) #1881

merged 1 commit into from
May 12, 2018

Conversation

@lrita
Copy link
Contributor

@lrita lrita commented May 4, 2018

Make sure these boxes checked before submitting your pull request.

  • Do only one thing
  • No API-breaking changes
  • [] New code/logic commented & tested

For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.

What did this pull request do?

Fixes issue #1830 when db Rollback()

2018/05/04 11:35:02 http: panic serving 127.0.0.1:51133: runtime error: invalid memory address or nil pointer dereference
goroutine 257 [running]:
net/http.(*conn).serve.func1(0xc42027a640)
        .../dev/go/src/net/http/server.go:1726 +0xd0
panic(0x14600e0, 0x17842e0)
        .../dev/go/src/runtime/panic.go:505 +0x229
database/sql.(*Tx).rollback(0x0, 0x14c5500, 0x1, 0x1a96480)
        .../dev/go/src/database/sql/sql.go:1944 +0x2d
database/sql.(*Tx).Rollback(0x0, 0x1a91408, 0x0)
        .../dev/go/src/database/sql/sql.go:1963 +0x30
github.com/jinzhu/gorm.(*DB).Rollback(0xc4206ee1b0, 0x1530670)
        .../dev/app/src/github.com/jinzhu/gorm/main.go:506 +0xa4

@jinzhu jinzhu merged commit a58b98a into go-gorm:master May 12, 2018
iahmedov pushed a commit to housinganywhere/gorm that referenced this pull request Sep 3, 2018
@lrita @iahmedov
Do not panic if Begin().Error was ignored (go-gorm#1830) (go-gorm#1881)
3e4dd7a
blefevre pushed a commit to blefevre/gorm that referenced this pull request Feb 17, 2020
@lrita @jinzhu
Do not panic if Begin().Error was ignored (go-gorm#1830) (go-gorm#1881)
1841dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lrita @jinzhu