fix:throw model value required error #6031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExerciseBook
reviewed
Feb 6, 2023
statement.go
Outdated
| } else if len(stmt.Schema.DBNames) > 0 { | ||
| write(v.Raw, stmt.Schema.DBNames[0]) | ||
| } else { | ||
| stmt.DB.AddError(ErrModelValueRequired) //nolint:typecheck,errcheck |
There was a problem hiding this comment.
Why we don't use ErrPrimaryKeyRequired.
I am not very familiar with gorm. Maybe I asked a stupid question.
I am not very sure what the meaning ErrPrimaryKeyRequired and ErrModelValueRequired are.
There was a problem hiding this comment.
@ExerciseBook This has nothing to do with the primary key, it's because there aren't any accessible fields in the model.
The use of ErrModelValueRequired here is indeed misleading. It prompts the user to use the model, but the problem here is that the user uses the wrong model.
jinzhu
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
close #6030
User Case Description