Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: begin transaction fail, rollback panic #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

fix: begin transaction fail, rollback panic #6365

merged 1 commit into from
May 31, 2023

Conversation

@zhouit
Copy link
Contributor

@zhouit zhouit commented May 31, 2023 •
edited
Loading

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

fix begin transaction fail, rollback panic

User Case Description

tx = db.Begin()  // when begin error

err := tx.Where(sql).Update(m).Err
if err = nil{
  tx.Rollback()   // will panic
  return err
}

tx.Commit()

@jinzhu jinzhu merged commit 740f2be into go-gorm:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinzhu jinzhu jinzhu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhouit @jinzhu