Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SergeiSadov
Copy link
Contributor

@SergeiSadov SergeiSadov commented May 9, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

While replacing associations using an example from the docs panic occurs.

db.Model(&user).Association("Languages").Replace(Language{Name: "DE"}, languageEN)

image

This PR fixes this issue by asserting if the value addressable and checking for the association error later.

User Case Description

Here is the PR for the playground example: go-gorm/playground#734
This is not the obvious case, but the code should not panic in the case but handle the invalid value gracefully

@jinzhu jinzhu merged commit 78c6dfd into go-gorm:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants