fwk: rename package testdata to internal/fwktest #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkdir -p fwk/internal/fwktest git mv fwk/testdata/*.go fwk/internal/fwktest ( cd fwk/internal/fwktest; sed -i '' 's/package testdata/package fwktest/' *.go ) git add fwk/internal/fwktest
( cd fwk; find . -name '*.go' -exec grep -Hq 'fwk/testdata' '{}' \; -print | xargs sed -i '' -e 's!fwk/testdata!fwk/internal/fwktest!' -e 's!testdata\.!fwktest.!' -e 's!some tools defined in testdata!some tools defined in fwktest!' )
sbinet
approved these changes
May 6, 2022
There was a problem hiding this comment.
LGTM.
thanks for cleaning that up.
like for the other pending PRs, please send another (just one) pull request against the go-hep/license repository, adding yourself to the AUTHORS and/or CONTRIBUTORS file(s).
then I'll be able to collect and merge all your other pull requests.
(I can't do that before you've added yourself to the list of authors/contributors of the Go-HEP project)
thanks.
|
ah. one finnicky import ordering that doesn't suit |
Apply gofmt after automated changes in previous commits.
|
I'll handle the thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941 .
1st commit:
2nd commit: