all: apply loopvar fixups #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastien Binet <[email protected]>
This CL adds a struct-field type/tag consistency check when creating
ReadVars from structs.
Basically, it's (for now) to detect mismatches between capacities of arrays
from the Go type with that of the groot-tag.
e.g.:
struct {
AOk [6]int64
Bad [7]int64
}
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 72.79% 72.87% +0.08%
==========================================
Files 420 420
Lines 63701 63749 +48
==========================================
+ Hits 46372 46460 +88
+ Misses 14945 14902 -43
- Partials 2384 2387 +3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.