Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

p5: fix outdated example in documentation #62

Merged
merged 2 commits into from
Nov 22, 2023
Merged

p5: fix outdated example in documentation #62

merged 2 commits into from
Nov 22, 2023

Conversation

@LCRERGO
Copy link
Contributor

@LCRERGO LCRERGO commented Nov 9, 2023

The main example of the library on godoc shows
an outdated use of the Square function where it has 4 arguments instead of 3.

Fixes #61

@codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e35d212) 83.01% compared to head (c907ad4) 83.01%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files           9        9           
  Lines         842      842           
=======================================
  Hits          699      699           
  Misses        122      122           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbinet
Copy link
Contributor

sbinet commented Nov 9, 2023

thanks a lot.

could you send another PR, adding yourself to the AUTHORS and/or CONTRIBUTORS file(s) ?
thanks again.

sbinet
sbinet approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LCRERGO
Copy link
Contributor Author

LCRERGO commented Nov 9, 2023

thanks a lot.

could you send another PR, adding yourself to the AUTHORS and/or CONTRIBUTORS file(s) ? thanks again.

Sure

@sbinet
Copy link
Contributor

sbinet commented Nov 10, 2023

sorry, I probably wasn't very clear.

could you create another pull request where you add yourself to the AUTHORS and/or CONTRIBUTORS file(s) (and modify this pull request to only contain code/doc modification) ?

or modify this pull request to have 2 commits, one with the authorship stuff and the other one with the code/doc edition ?

(apologies for being picky)

thanks again.

@LCRERGO
p5: fix outdated example in documentation
28f6829 
The main example of the library on godoc shows
an outdated use of the Square function where it has
4 arguments instead of 3.

Fixes go-p5#61
@LCRERGO
doc: add a contributor entry
c907ad4
@LCRERGO
Copy link
Contributor Author

LCRERGO commented Nov 22, 2023

Sorry for the delay to answer, but take a look if it is all right now

@sbinet sbinet merged commit e5f7503 into go-p5:main Nov 22, 2023
@sbinet
Copy link
Contributor

sbinet commented Nov 22, 2023

thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sbinet sbinet sbinet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Entry on documentation outdated

2 participants

@LCRERGO @sbinet