This repository was archived by the owner on Apr 23, 2025. It is now read-only.
p5: better handling of closed paths #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect shapes that are expected to be closed paths and properly close the Gio path. This fixes not quite closed paths because of float32 rounding errors. Fixes #63. Signed-off-by: Sebastien Binet <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 83.01% 83.17% +0.15%
==========================================
Files 9 9
Lines 842 850 +8
==========================================
+ Hits 699 707 +8
Misses 122 122
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect shapes that are expected to be closed paths and properly close the Gio path.
This fixes not quite closed paths because of float32 rounding errors.
Fixes #63.