feat(tools): evaluate\selector\screenshot #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeoxisca
commented
Apr 2, 2025
- beautify tool key, use global const key to constraint tool name
- add createTab\evaluate\selector\screenshot handler functions
Collaborator
|
LGTM |
Collaborator
|
I suggest turning off this PR. You can add a new PR except for |
Author
|
Done, createTab removed |
Fly-Playgroud
approved these changes
Apr 13, 2025
tools/common.go
Outdated
Comment on lines
199
to
201
| if element == nil || element.Object == nil { | ||
| return nil, errors.New(fmt.Sprintf("Failed to find element: %s", selector)) | ||
| } |
Collaborator
There was a problem hiding this comment.
the same as fill handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.