feat: api v1 #1157
Open
feat: api v1 #1157
+17,970
−2,473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement CRUD handlers: create, list, get, update, delete bookmarks - Add domain methods: CreateBookmark, UpdateBookmark, DeleteBookmarks - Comprehensive test suite with 47 handler tests and 24 domain tests - Edge case coverage: validation, pagination, concurrent access - Proper error handling and authentication requirements - Tag management with duplicate handling and clearing support Co-authored-by: Ona <[email protected]>
Co-authored-by: Ona <[email protected]>
- Tag creation API returns 204 No Content if tag already exists - Frontend searches for existing tags before creating - Bookmark creation defaults title to URL when not provided - Add unit tests for new behavior
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 50.19% 51.47% +1.27%
==========================================
Files 75 75
Lines 7532 8101 +569
==========================================
+ Hits 3781 4170 +389
- Misses 3414 3567 +153
- Partials 337 364 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Restructure BookmarkCard layout to properly align actions to bottom edge - Move actions outside padded content area for true bottom alignment - Add auto-rows-fr to grid container for consistent card heights - Improve icon consistency and hover states - Replace Button components with native buttons for better control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.