Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix invalid base URL assignment #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asciimoo merged 1 commit into from
Oct 13, 2020
Merged

Fix invalid base URL assignment #549

asciimoo merged 1 commit into from
Oct 13, 2020

Conversation

@dasshield
Copy link
Contributor

@dasshield dasshield commented Oct 11, 2020

closes #535

asciimoo
asciimoo approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@asciimoo asciimoo merged commit 1735be1 into gocolly:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asciimoo asciimoo asciimoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Colly should not set baseURL on requests for invalid base URLs

2 participants

@dasshield @asciimoo