Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@houseme
Copy link

@houseme houseme commented Mar 28, 2025

  1. Remove github.com/gocolly/colly dependency from go.mod
  2. Upgrade golang.org/x/net and github.com/jawher/mow.cli dependencies
  3. Format import statements in code
  4. Update actions/checkout and actions/setup-go versions in ci.yml
  5. Add .gitignore file
  6. Improve and update README.md file

@asciimoo

1. Remove `github.com/gocolly/colly` dependency from `go.mod`
2. Upgrade `golang.org/x/net` and `github.com/jawher/mow.cli` dependencies
3. Format `import` statements in code
4. Update `actions/checkout` and `actions/setup-go` versions in `ci.yml`
5. Add `.gitignore` file
6. Improve and update `README.md` file
@houseme houseme requested a review from asciimoo March 30, 2025 12:13
…-1.2.0

* 'master' of github.com:gocolly/colly:
  use slices package to copy
  use slices package to delete
  fix data race
@houseme
Copy link
Author

houseme commented Apr 1, 2025

@asciimoo

1 similar comment
@houseme
Copy link
Author

houseme commented Apr 17, 2025

@asciimoo

@WGH-
Copy link
Collaborator

WGH- commented May 23, 2025

What's the reason to bump github.com/jawher/mow.cli in particular?

@houseme
Copy link
Author

houseme commented Jun 13, 2025

What's the reason to bump github.com/jawher/mow.cli in particular?

upgrade version

Copilot AI review requested due to automatic review settings December 8, 2025 15:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the project's dependencies, CI configuration, and documentation to improve maintainability and adopt current best practices. The changes include removing an unused dependency, upgrading packages to newer versions, standardizing Go import formatting across the codebase, and updating GitHub Actions to more recent versions.

Key changes:

  • Removed unused github.com/gocolly/colly v1 dependency from go.mod and upgraded github.com/jawher/mow.cli from v1.1.0 to v1.2.0
  • Reformatted import statements to follow Go conventions (standard library, third-party, local packages with blank line separators)
  • Updated CI workflow to use actions/[email protected] and actions/[email protected]

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Removes unused colly v1 dependency and upgrades mow.cli to v1.2.0
go.sum Updates checksums for modified dependencies (contains duplicate entries that need cleanup)
xmlelement_test.go Reformats imports to follow Go conventions with proper grouping
http_backend.go Moves compress/gzip import to standard library group at the top
colly.go Reorganizes imports to separate local packages from third-party
README.md Improves installation instructions and adds package declaration to example (markdown formatting issue)
.github/workflows/ci.yml Updates GitHub Actions versions and standardizes YAML formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants