-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Refactor project dependencies, CI configuration, and documentation #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1. Remove `github.com/gocolly/colly` dependency from `go.mod` 2. Upgrade `golang.org/x/net` and `github.com/jawher/mow.cli` dependencies 3. Format `import` statements in code 4. Update `actions/checkout` and `actions/setup-go` versions in `ci.yml` 5. Add `.gitignore` file 6. Improve and update `README.md` file
…-1.2.0 * 'master' of github.com:gocolly/colly: use slices package to copy use slices package to delete fix data race
1 similar comment
|
What's the reason to bump |
upgrade version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the project's dependencies, CI configuration, and documentation to improve maintainability and adopt current best practices. The changes include removing an unused dependency, upgrading packages to newer versions, standardizing Go import formatting across the codebase, and updating GitHub Actions to more recent versions.
Key changes:
- Removed unused
github.com/gocolly/collyv1 dependency from go.mod and upgradedgithub.com/jawher/mow.clifrom v1.1.0 to v1.2.0 - Reformatted import statements to follow Go conventions (standard library, third-party, local packages with blank line separators)
- Updated CI workflow to use
actions/[email protected]andactions/[email protected]
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Removes unused colly v1 dependency and upgrades mow.cli to v1.2.0 |
| go.sum | Updates checksums for modified dependencies (contains duplicate entries that need cleanup) |
| xmlelement_test.go | Reformats imports to follow Go conventions with proper grouping |
| http_backend.go | Moves compress/gzip import to standard library group at the top |
| colly.go | Reorganizes imports to separate local packages from third-party |
| README.md | Improves installation instructions and adds package declaration to example (markdown formatting issue) |
| .github/workflows/ci.yml | Updates GitHub Actions versions and standardizes YAML formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github.com/gocolly/collydependency fromgo.modgolang.org/x/netandgithub.com/jawher/mow.clidependenciesimportstatements in codeactions/checkoutandactions/setup-goversions inci.yml.gitignorefileREADME.mdfile@asciimoo