Multipart body should not be map[string][]byte #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap for multipart requests The PostMultipart function now takes a slice of FormField structs, allowing for more structured handling of form data, including optional filenames. The createMultipartReader function has also been updated accordingly to accommodate this change.
…rm data handling The PostMultipart function has been modified to accept a slice of FormField structs instead of a map, enhancing the structure and flexibility of multipart requests. The createMultipartReader function has been adjusted to support this change.
Implemented tests for the Collector's PostMultipart method, covering basic multipart form submissions, file uploads, and submissions with different fields. Enhanced the test server to handle multipart form data correctly, ensuring robust validation of response status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fartin' around, saw #822 and wanted to see what Cursor thought.