Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Increment i before return True #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asciimoo merged 2 commits into from
Oct 28, 2018
Merged

Increment i before return True #246

asciimoo merged 2 commits into from
Oct 28, 2018

Conversation

@nigelbabu
Copy link
Contributor

@nigelbabu nigelbabu commented Oct 27, 2018

The counter does not get incremented at all at the moment

Increment i before return True
9d64053 
The counter does not get incremented at all at the moment
@nigelbabu
Copy link
Contributor Author

nigelbabu commented Oct 27, 2018

There doesn't seem to be any tests for htmlelement.go, so I haven't added one. If I have somehow missed them, please let me know.

asciimoo
asciimoo approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@asciimoo asciimoo merged commit 8be5ab8 into gocolly:master Oct 28, 2018
@nigelbabu nigelbabu deleted the fix-index-for-each-with-brk branch October 28, 2018 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asciimoo asciimoo asciimoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nigelbabu @asciimoo