fix: wrong the detection method of nilable #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 79.95% 79.90% -0.06%
==========================================
Files 52 52
Lines 17555 17561 +6
==========================================
- Hits 14036 14032 -4
- Misses 2951 2960 +9
- Partials 568 569 +1 |
|
Thank you for contribution !! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #339
isNilable didn't consider the case where typ is a direct interface.
So, the number of dereferencing is not correct and the function is called with an incorrect receiver address, resulting in panic.