refine the cron ehpa to single metric for multiple crons #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1a42a0 to
7a17fb4
Compare
qmhu
reviewed
Mar 23, 2022
| metadata: | ||
| name: metric-adapter | ||
| rules: | ||
| - apiGroups: |
Member
There was a problem hiding this comment.
@mfanjie suggest not use too wide regex for rbac before, so do we have to change to * ?
Contributor
Author
There was a problem hiding this comment.
Because now the adapter need to list the workload scale to get the current replicas when cron is not active, we do not know what kind group, it will forbidden when not specified
Member
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
Now, cron has some flaws if only specified one cron, then if the time is not in cron start and end, the metric will be default 1. it is unexpected for users.
Mapping many crons in one ehpa to only one metric, put many cron compare logic in metric-adapter to solve this problem.
Which issue(s) this PR fixes:
Fixes #226
Special notes for your reviewer: