Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@koplas
Copy link
Contributor

@koplas koplas commented Nov 27, 2024

This allows other programs like google/licensecheck to correctly detect the license. This is required to display the documentation in pkg.go.dev.

This allows other programs like google/licensecheck to correctly
detect the license. This is required to display the documentation
in `pkg.go.dev`.
@bernhardreiter
Copy link
Member

As this is unneeded by the reuse.standard, we want to improve the software that does the detection pkg.go.dev and prefer it over this this cludge.

@bernhardreiter bernhardreiter marked this pull request as draft November 28, 2024 10:55
@koplas
Copy link
Contributor Author

koplas commented Dec 23, 2024

As this is unneeded by the reuse.standard, we want to improve the software that does the detection pkg.go.dev and prefer it over this cludge.

If we want to provide documentation on pkg.go.dev, we have no other option. See: golang/go#40586 (comment)

@bernhardreiter
Copy link
Member

If we want to provide documentation on pkg.go.dev, we have no other option

We can still create the patch in the first place.

@koplas koplas marked this pull request as ready for review January 6, 2025 15:01
@koplas
Copy link
Contributor Author

koplas commented Jan 6, 2025

We cannot control Google's infrastructure.

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik lgtm

Copy link
Contributor

@cintek cintek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cintek cintek merged commit ed22136 into main Jan 23, 2025
1 check passed
@cintek cintek deleted the copy-license branch January 23, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants