Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bernhardreiter
Copy link
Member

.. that we cannot or do not want to fix yet

For better naming for variables like ProductIds, we must wait for the next release.
With util we may just keep it.

This is based on #695, so merge #695 first.

close #682

  raise minium version of go compatiblity to 1.24.9
  and toolchain to be used to 1.25.3
  * update all .github/workflows/ to use the latest version of
    actions and the go versions accordingly.
    (Only some github actions use a floating tag for the major version.)
  * reduce places where the go versions are hardcoded:
      * refEr to docs/Development.md from README.md
      * use `go.mod` from itest.yml.
  and thus makes newer go test versions happy
  that we cannot or do not want to fix yet
@github-actions
Copy link

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's minor version number.

minimum Go version changed from 1.23.0 to 1.24.9
  Minor

Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't silence all warnings, but many without introducing new ones so LGTM & works

@JanHoefelmeyer JanHoefelmeyer merged commit 8dd4cb4 into main Oct 27, 2025
7 checks passed
@JanHoefelmeyer JanHoefelmeyer deleted the slient-revive branch October 27, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

silence linter ID warning

4 participants