Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ROLIE: Add category to entries #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanHoefelmeyer merged 4 commits into from
Dec 1, 2025
Merged

ROLIE: Add category to entries #703

JanHoefelmeyer merged 4 commits into from
Dec 1, 2025

Conversation

@s-l-teichmann
Copy link
Contributor

@s-l-teichmann s-l-teichmann commented Nov 19, 2025

Allow parsing of category fields in ROLIE entries.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025 •
edited
Loading

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's minor version number.

checking *ROLIEFeed.EntryByID
  in results of func(id string) *github.com/gocsaf/csaf/v3/csaf.Entry
    struct field Base was added to github.com/gocsaf/csaf/v3/csaf.Entry
      Minor

@bernhardreiter bernhardreiter marked this pull request as draft November 19, 2025 14:25
@bernhardreiter bernhardreiter mentioned this pull request Nov 20, 2025
Closed
@bernhardreiter
Copy link
Member

bernhardreiter commented Nov 20, 2025

Comparision of allowed entry elements to what would the code accept with these changes applied:

https://www.rfc-editor.org/rfc/rfc4287

RELAX NG Schema

   atomCommonAttributes =
      attribute xml:base { atomUri }?,
      attribute xml:lang { atomLanguageTag }?,
      undefinedAttribute*
      
   undefinedAttribute =
     attribute * - (xml:base | xml:lang | local:*) { text }

https://www.rfc-editor.org/rfc/rfc8322.html#section-6.2

   atomEntry =
       element atom:entry {
-         atomCommonAttributes,
-		(atomAuthor*
x         & atomCategory*
x         & atomContent
-         & atomContributor*
x         & atomId
x         & atomLink*
x         & atomPublished?
-         & atomRights?
-         & atomSource?
x         & atomSummary?
x        & atomTitle
x         & atomUpdated
x         & rolieFormat?
-         & rolieProperty*
?         & extensionElement*)
     }
  • x == exists
  • - == missing

@bernhardreiter
Copy link
Member

bernhardreiter commented Nov 20, 2025 •
edited
Loading

Given the open research question about undefinedAttribute* written down at the bottom if github.com//issues/702#issuecomment-3553564822, my suggestion is that we improve the implementation by adding everything, except undefinedAttribute* and extensionElement and document the open question to resolve.

@bernhardreiter bernhardreiter marked this pull request as ready for review November 27, 2025 14:29
bernhardreiter
bernhardreiter approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernhardreiter
Copy link
Member

bernhardreiter commented Nov 28, 2025

We could potentially mention in the docs somewhere that not support undefinedAttribute* and do not support extensionElement .

JanHoefelmeyer
JanHoefelmeyer approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@JanHoefelmeyer JanHoefelmeyer merged commit 9393271 into main Dec 1, 2025
8 checks passed
@JanHoefelmeyer JanHoefelmeyer deleted the add_rolie_category branch December 1, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernhardreiter bernhardreiter bernhardreiter approved these changes

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@cintek cintek Awaiting requested review from cintek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@s-l-teichmann @bernhardreiter @JanHoefelmeyer