Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tchssk
Copy link
Member

@tchssk tchssk commented Oct 4, 2024

No description provided.

@tchssk tchssk force-pushed the codegen-fixreservedgo-ispredeclared branch from 4ac46cc to 8e62659 Compare October 4, 2024 15:40
@tchssk tchssk changed the title Use doc.IsPredeclared() for codegen.fixReservedGo() Use doc.IsPredeclared() and token.IsKeyword() for codegen.fixReservedGo() Oct 4, 2024
@tchssk tchssk marked this pull request as ready for review October 4, 2024 15:53
Copy link
Member

@raphael raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great! Do we also need to consider the std lib package names separately?

@tchssk
Copy link
Member Author

tchssk commented Oct 11, 2024

Oops! I added a condition.

@raphael
Copy link
Member

raphael commented Oct 13, 2024

Perfect, thank you!

@raphael raphael merged commit 6de544f into goadesign:v3 Oct 13, 2024
9 checks passed
@tchssk tchssk deleted the codegen-fixreservedgo-ispredeclared branch October 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants