Fix #3745: Generate conversion functions per package #3748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pkg:path metadata
This fix resolves the issue where ConvertTo/CreateFrom functions were generated
in the wrong directory when types have Meta("struct:pkg:path") metadata.
Changes:
- Replace ConvertFile with ConvertFiles to support multi-package generation
- Group conversions by target package path using UserTypeLocation
- Add SamePackageConversion flag to AttributeContext for proper type references
- Add comprehensive test coverage for multi-package conversion scenarios
- Update service generator to use new ConvertFiles function
- Add branch naming conventions to CLAUDE.md
The implementation follows the existing multi-package pattern used in service.go
and ensures that conversion functions are generated in the correct package
directory while maintaining proper type qualification.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Replace manual string slicing with filepath.Dir() for cross-platform compatibility - Add filepath.FromSlash() in tests to normalize path separators - Fixes GitHub Actions Windows test failure in TestConvertFiles 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves the issue where ConvertTo/CreateFrom functions were generated in the wrong directory when types have Meta("struct:pkg:path") metadata.
Changes:
The implementation follows the existing multi-package pattern used in service.go and ensures that conversion functions are generated in the correct package directory while maintaining proper type qualification.