fix: Reserve service package name in HTTP codegen and fix SSE error handling in JSON-RPC #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the SSE server stream template to correctly handle multiple error responses by iterating through nested error structures. - Ensured that the generated code properly emits error handling cases for each defined error, improving robustness in SSE implementations. Tests: all unit tests pass; JSON-RPC integration tests pass.
…meter name collisions - Updated the analyze method in ServicesData to reserve the service package name, ensuring it does not conflict with parameter names in generated code. Tests: all unit tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP: Reserve the service package identifier so generated endpoint parameter names do not collide with it in user code.
JSON-RPC (SSE): Ensure errors are surfaced correctly during server-sent events streaming.
Scope