Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate duplicate TypeName for declared types; ignore generated (Fixes #3799) #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2025
Merged

Validate duplicate TypeName for declared types; ignore generated (Fixes #3799) #3801

merged 1 commit into from
Sep 13, 2025

Conversation

@raphael
Copy link
Member

@raphael raphael commented Sep 13, 2025

This PR fixes #3799 by adding Root-level validation for TypeName collisions.

Changes

  • ResultType: error when multiple declared ResultType definitions share the same TypeName. Generated result types (e.g., CollectionOf) are skipped by checking absence of openapi:typename meta.
  • UserType: error when multiple declared user types share the same TypeName.
  • Tests: add dedicated DSL repros and validation tests for both cases.
  • Docs: remove docs/zuplo.png and docs/zuplo-dark.png.

Behavior

  • Designs that previously generated conflicting code now fail validation early with a clear error.

Implementation notes

  • Validation occurs after DSL execution to account for TypeName applied inside DSL.
  • Identifier collisions for ResultType remain enforced at DSL time.

@raphael
validate: error on duplicate TypeName for declared user/result types;…
d83919e 
… ignore generated collections (Fixes #3799)

- Add Root-level checks:
  - ResultType: detect TypeName collisions only among declared types (meta openapi:typename), skipping generated collection types.
  - UserType: detect TypeName collisions across declared user types.
- Add tests and DSL repros for both cases.
- Remove docs images: docs/zuplo.png, docs/zuplo-dark.png
@raphael raphael enabled auto-merge (squash) September 13, 2025 06:05
@raphael raphael merged commit be66eab into v3 Sep 13, 2025
7 checks passed
@raphael raphael deleted the fix/duplicate-typenames-issue-3799 branch September 13, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Given repeat TypeNames Goa generates invalid code

1 participant

@raphael