Add support for custom tags and GOBLET_ARTIFACT_TAG env var#443
Merged
anovis merged 5 commits intogoblet:mainfrom Oct 12, 2023
nthings:INFRA-1715-goblet-deployment-tagging-enhancements
Merged
Add support for custom tags and GOBLET_ARTIFACT_TAG env var#443anovis merged 5 commits intogoblet:mainfrom nthings:INFRA-1715-goblet-deployment-tagging-enhancements
anovis merged 5 commits intogoblet:mainfrom
nthings:INFRA-1715-goblet-deployment-tagging-enhancements
Conversation
added 5 commits
October 10, 2023 14:13
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 89.50% 89.63% +0.13%
==========================================
Files 62 62
Lines 5601 5634 +33
==========================================
+ Hits 5013 5050 +37
+ Misses 588 584 -4
☔ View full report in Codecov by Sentry. |
Collaborator
|
Awesome! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #433 and #432