Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nthings
Copy link
Contributor

@nthings nthings commented Oct 10, 2023

solves #433 and #432

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12199a1) 89.50% compared to head (f16b4cc) 89.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   89.50%   89.63%   +0.13%     
==========================================
  Files          62       62              
  Lines        5601     5634      +33     
==========================================
+ Hits         5013     5050      +37     
+ Misses        588      584       -4     
Files Coverage Δ
goblet/backends/cloudrun.py 78.52% <100.00%> (+1.79%) ⬆️
goblet/revision.py 89.74% <100.00%> (+2.56%) ⬆️
goblet/tests/test_deployer.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anovis
Copy link
Collaborator

anovis commented Oct 12, 2023

Awesome! thank you!

@anovis anovis merged commit cedebc4 into goblet:main Oct 12, 2023
@nthings nthings deleted the INFRA-1715-goblet-deployment-tagging-enhancements branch October 12, 2023 14:43
quajones pushed a commit to quajones/goblet that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants