Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Docs] Enhance README and CONTRIBUTING files #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anovis merged 2 commits into from
Nov 22, 2023
Merged

[Docs] Enhance README and CONTRIBUTING files #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55a98cb
Refer to CONTRIBUTING.md in README and add a note on requests-mock pa…
mmyoussef Nov 21, 2023
e528386
Merge branch 'main' into docs/mention_contribution_file_and_requests_…
mmyoussef Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ clone repo `git clone [email protected]:goblet/goblet.git`
install local version in your env by `pip install -e .`


If you are running into issues running tests make sure to set your pythonpath.
**If you are running into issues running tests,** make sure to set your pythonpath.

```export PYTHONPATH=$(pwd)```

and install requests-mock

```pip install requests-mock```
## Writing Tests

* When mocking tests that interact with GCP you will notice the following env vars set.
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ Please file any issues, bugs or feature requests as an issue on our [GitHub](htt

## Want to Contribute

If you would like to contribute to the library (e.g. by improving the documentation, solving a bug or adding a cool new feature) submit a [pull request](https://github.com/goblet/goblet/pulls).
If you would like to contribute to the library (e.g. by improving the documentation, solving a bug or adding a cool new feature) please follow the [contribution guide](CONTRIBUTING.md) and submit a [pull request](https://github.com/goblet/goblet/pulls).

## Want to Support

Expand Down