GOBLET_BUILD_TAGS and GOBLET_ARTIFACT_BUCKET for cloudfunctionv1 #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code to a bucket and use the file in the bucket to create the cloudfunction v1
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 89.57% 89.62% +0.05%
==========================================
Files 69 69
Lines 6349 6412 +63
==========================================
+ Hits 5687 5747 +60
- Misses 662 665 +3 ☔ View full report in Codecov by Sentry. |
873e4fe to
7d6f7f8
Compare
…ACT_BUCKET or using `deploy.artifact_bucket` in config.json. same for GOBLET_ARTIFACT_TAG and `deploy.artifact_tag`
anovis
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload the code to GOBLET_UPLOAD_BUCKET tagged with first tag in GOBLET_BUILD_TAGS
deploy cloudfunctionv1 from GOBLET_UPLOAD_BUCKET + GOBLET_ARTIFACT_TAG (closes #447 )