Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Register nested handlers correctly #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anovis merged 4 commits into from
Mar 18, 2024
Merged

Register nested handlers correctly #484

anovis merged 4 commits into from
Mar 18, 2024

Conversation

@anovis
Copy link
Collaborator

@anovis anovis commented Mar 10, 2024

The following will now register the scheduler and job at the same time correctly.

@app.job("testjob2", schedule="* * * * *")
@app.stage(stages=["TEST"])
def test_cloudrun_job2(id):
    run_job()

@codecov
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 90.38462% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.62%. Comparing base (b644efa) to head (1843271).

Files Patch % Lines
goblet/tests/test_jobs.py 82.60% 4 Missing ⚠️
goblet/tests/test_pubsub_subscription.py 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   89.62%   89.62%   -0.01%     
==========================================
  Files          69       69              
  Lines        6412     6455      +43     
==========================================
+ Hits         5747     5785      +38     
- Misses        665      670       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anovis anovis mentioned this pull request Mar 12, 2024
Closed
@kylejohnson514 kylejohnson514 mentioned this pull request Mar 18, 2024
Closed
@anovis anovis merged commit 8d32627 into main Mar 18, 2024
@anovis anovis deleted the register-nested-handlers branch March 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cloud run jobs specifying an environment via app.stage() with schedule decorator still deploy cloud scheduler to all envs

2 participants

@anovis