Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alissonpelizaro
Copy link
Contributor

@alissonpelizaro alissonpelizaro commented Apr 24, 2024

This PR checks if there is missing an 3rd argument on Tuples route responses and manage it properly when CORS is enabled. (closes #490 )

@anovis
Copy link
Collaborator

anovis commented Apr 24, 2024

@alissonpelizaro looks like the lint check is failing.

you can do pip install black and run black .

you can verify it works by running make lint locally

@alissonpelizaro
Copy link
Contributor Author

Done @anovis . I removed the whitespaces, it's ok now.

@anovis
Copy link
Collaborator

anovis commented Apr 25, 2024

Done @anovis . I removed the whitespaces, it's ok now.

awesome! thank you!

@anovis anovis merged commit 7a5b7e7 into goblet:main Apr 25, 2024
@alissonpelizaro
Copy link
Contributor Author

Hi @anovis
It seems this aren't working properly, it's trying to inject headers on status_code's tuple index depending on the way that the response is returned. I would consider revert this PR.

alissonpelizaro added a commit to alissonpelizaro/goblet that referenced this pull request Apr 29, 2024
@anovis
Copy link
Collaborator

anovis commented Apr 29, 2024

@alissonpelizaro thanks for letting me know. can you open a new issue and share an example error message that you are seeing?

@alissonpelizaro
Copy link
Contributor Author

@anovis Actually its working well, please desconsider...
I faced an error and I thought its relates to the new version, but it was my fault, I used Response params in a wrong sequence in my tests. 🥴

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't return Tuple responses when CORS is enabled

2 participants