[cloudrun] enable cloudbuild network for cloudbuild step #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anovis
reviewed
Jan 5, 2023
Dockerfile
Outdated
| WORKDIR $APP_HOME | ||
|
|
||
| # Install dependencies. | ||
| RUN pip install keyrings.google-artifactregistry-auth==1.1.1 |
Collaborator
There was a problem hiding this comment.
not sure we want to include this pip install in the default Dockerfile. may be worth noting in the docs on how to add in order to install packages from a private repository.
actually we can add a comment so folks can uncomment as needed.
Collaborator
There was a problem hiding this comment.
do we need pip install keyring as well?
Contributor
Author
There was a problem hiding this comment.
keyring is installed as a dependency
anovis
reviewed
Jan 5, 2023
| { | ||
| "name": "gcr.io/cloud-builders/docker", | ||
| "args": ["build", "-t", registry, "."], | ||
| "args": ["build", "--network=cloudbuild", "-t", registry, "."], |
Collaborator
There was a problem hiding this comment.
nice. we can keep this as the default!
anovis
reviewed
Jan 5, 2023
goblet/write_files.py
Outdated
| WORKDIR $APP_HOME | ||
| # Install dependencies. | ||
| RUN pip install keyrings.google-artifactregistry-auth==1.1.1 |
Collaborator
There was a problem hiding this comment.
add as a comment in addition to a comment explaining when it would be needed.
anovis
requested changes
Jan 5, 2023
Dockerfile
Outdated
| WORKDIR $APP_HOME | ||
|
|
||
| # Install dependencies. | ||
| RUN pip install keyrings.google-artifactregistry-auth==1.1.1 |
Collaborator
There was a problem hiding this comment.
do we need pip install keyring as well?
quajones
added a commit
to quajones/goblet
that referenced
this pull request
Oct 19, 2023
- exposes cloudbuild network to docker build container, will enable access to ADC credentials within cloudbuild steps: https://cloud.google.com/build/docs/build-config-file-schema#network - adding keyrings to the Dockerfile will handle authentication and allow services to install packages directly from artifact registry: https://cloud.google.com/artifact-registry/docs/python/authentication#keyring (is required to be installed before packages can be installed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.