Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allow passthrough for jsonify parameters #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anovis merged 4 commits into from
Jan 24, 2023
Merged

allow passthrough for jsonify parameters #302

anovis merged 4 commits into from
Jan 24, 2023

Conversation

@quajones
Copy link
Contributor

@quajones quajones commented Jan 10, 2023

No description provided.

@quajones quajones marked this pull request as ready for review January 10, 2023 18:33
anovis
anovis requested changes Jan 16, 2023
View reviewed changes
@quajones quajones marked this pull request as draft January 19, 2023 18:30
@quajones quajones changed the title default to str for non serializable objects allow passthrough for jsonify parameters Jan 23, 2023
@quajones quajones marked this pull request as ready for review January 23, 2023 22:51
@quajones quajones requested a review from anovis January 24, 2023 15:17
anovis
anovis approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@anovis anovis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thank you!

@anovis anovis merged commit 15a4f9e into goblet:main Jan 24, 2023
@quajones quajones deleted the jsonify-default branch January 24, 2023 21:56
quajones added a commit to quajones/goblet that referenced this pull request Oct 19, 2023
@quajones
Passthrough for jsonify parameters (goblet#302)
ff59da0 
* default to str for non serializable objects

* update jsonify to pass arguments, update tests

* lint fixes

* fix syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anovis anovis anovis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quajones @anovis