fixed delete + where in issue on mysql (#699)#784
Merged
Conversation
This was referenced Sep 24, 2022
Closed
sio4
commented
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Delete()+WHERE INissue on MySQL for #699.The direct cause was the implementation of
Delete(). When the query could haveWHERE IN, currently the query should be generated via SQLBuilder (specificallysqlx.In()insqlBuilder.compile()to expand?to match with the arguments.The root cause is the SQL syntax of MySQL. MySQL 5.7 does not support table alias for the
DELETEstatement, soAS table_aliascauses a syntax error. I guess theDelete()for MySQL has its own implementation for this reason. The syntax was changed in 8.0 so when 5.7 is fully EOSed, we can use the generic version here.fixes #699