fix(net/ghttp): Server Domain if is empty str, bind handler pattern will add @ which is not expect #4100#4101
Merged
hailaz merged 6 commits intogogf:masterfrom Sep 26, 2025
Merged
Conversation
gqcn
previously requested changes
Jan 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where binding handler patterns would incorrectly include an "@" character when the server domain is an empty string. The changes refactor the string concatenation logic by introducing a helper function that conditionally adds the "@" separator.
- Replaces inline concatenations with the new helper function patternBindDomain.
- Updates all handler binding methods to use the helper function.
- Introduces patternBindDomain to conditionally format the handler pattern.
Comments suppressed due to low confidence (2)
net/ghttp/ghttp_server_domain.go:170
- [nitpick] Consider adding a brief documentation comment for the helper function 'patternBindDomain' to explain its behavior, especially its handling of empty domain strings.
func patternBindDomain(pattern, domain string) string {
net/ghttp/ghttp_server_domain.go:170
- Consider adding unit tests for 'patternBindDomain', ensuring that the function behaves correctly with both empty and non-empty domain strings.
func patternBindDomain(pattern, domain string) string {
hailaz
approved these changes
Sep 26, 2025
hailaz
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4100