fix(util/gconv): fix incompatable converting to nil pointer target from older version implement #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r version implement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with incompatible converting to a nil pointer target as described in issue #4218. The changes refactor the conversion logic in the converter to avoid a duplicated type check and add unit tests for the fixed behavior.
- Refactored the Scan function in converter_scan.go to remove duplicate type checking and better handle nil pointer targets.
- Added a new unit test in gconv_z_unit_issue_test.go addressing issue #4218.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| util/gconv/internal/converter/converter_scan.go | Removed redundant type checking in Scan and improved nil pointer logic. |
| util/gconv/gconv_z_unit_issue_test.go | Added unit test to validate conversion behavior for issue #4218. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #4218