feat(util/gconv): support automatic conversion of Y/N string to bool
#4220
Conversation
|
@FSpark Thanks for your contribution. It indeed needs such implement for recognizing boolean value for oracle, but we should not convert string |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for converting Oracle CHAR(1) boolean representations into Go booleans, specifically enhancing compatibility with legacy database systems.
- Adds a new mapping for "n" to be interpreted as false.
- Supports automatic conversion of 'Y/N' strings, as indicated by the PR title.
Comments suppressed due to low confidence (1)
util/gconv/internal/converter/converter.go:51
- The PR title suggests support for both 'Y' and 'N' strings, yet this diff only adds a mapping for 'n'. Consider adding or verifying the presence of a corresponding mapping for 'y' to maintain symmetric behavior.
"n": {}
|
@FSpark You still updated the global converter. Such updates should be made in oracle implements. |
In Oracle databases, it is very common to use CHAR(1) fields with 'Y' or 'N' to represent boolean values. This PR adds support for interpreting 'Y' as true and 'N' as false to improve compatibility and developer experience.
Note:
Should we also consider adding support for 'T'/'F' as boolean equivalents? This pattern is also occasionally used in some legacy systems.