Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR marks existing pagination code as deprecated so that developers migrate the HTML pagination logic into the business layer.
- Added deprecation comments in the util/gpage package for both the Page type and the New function.
- Updated the error message in the net/ghttp package's GetPage method.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| util/gpage/gpage.go | Added deprecation warnings to indicate planned deprecation. |
| net/ghttp/ghttp_request_param_page.go | Updated panic message with lowercase, affecting error message consistency. |
Files not reviewed (1)
- examples: Language not supported
Comments suppressed due to low confidence (1)
net/ghttp/ghttp_request_param_page.go:25
- The panic message uses lowercase 'router' whereas it might be more consistent to use 'Router' as in other parts of the code. Consider aligning the casing for clarity.
panic("router object not found")
Member
Author
这种一般大版本移除。 |
This general large version is removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.