fix(gconv): fix scanning functionality for deep slice types#4272
Closed
fainc wants to merge 4 commits intogogf:masterfrom
Closed
fix(gconv): fix scanning functionality for deep slice types#4272fainc wants to merge 4 commits intogogf:masterfrom
fainc wants to merge 4 commits intogogf:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the scanning functionality for deep slice types by updating the error handling logic when scanning each slice element and adding new test coverage for deep slice conversions.
- Revised error handling in the scanning loop to conditionally return errors based on the ContinueOnError option.
- Added unit tests for deep slice scanning functionality.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| util/gconv/internal/converter/converter_scan.go | Updated error handling for scanning deep slice element types. |
| util/gconv/gconv_z_unit_scan_test.go | Added tests to validate deep slice scanning functionality. |
| err = c.Scan( | ||
| srcElem, newSlice.Index(i).Addr().Interface(), option..., | ||
| ) | ||
| if err != nil && !scanOption.ContinueOnError { |
There was a problem hiding this comment.
Ensure that the modified error handling strategy with scanOption.ContinueOnError is intentional; if errors are being skipped on purpose, consider logging or documenting this behavior to aid in debugging partial conversions.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4271