fix(net/ghttp): improve GetMetaTag method to handle nil and type checks#4284
Merged
fix(net/ghttp): improve GetMetaTag method to handle nil and type checks#4284
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential array out-of-bound issue in the GetMetaTag method by adding checks for nil pointers and ensuring the handler has the expected number of parameters.
- Added a compound conditional to validate h, h.Info.Type, and that h.Info.Type.NumIn() equals 2 before proceeding.
Contributor
|
SGTM |
houseme
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复没有做handler参数数量判断导致可能出现的数组越界问题