fix(internal/utils): fix +.1 is pass checks numeric#4374
Merged
hailaz merged 1 commit intogogf:masterfrom Aug 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the IsNumeric function where strings like "+.1" and "-.1" were incorrectly considered valid numeric values. The fix ensures that a decimal point must be preceded by a digit when it's not at the beginning of the string.
- Fixed the decimal point validation logic to require a preceding digit
- Added test cases to verify the fix for "+.1" and "-.1" edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/utils/utils_str.go | Updated IsNumeric function to check that decimal points are preceded by digits |
| internal/utils/utils_z_unit_test.go | Added test cases for "-.1" and "+.1" to verify they return false |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hailaz
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.