feat: update linter config and deprecation notice #4399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `gofmt` rewrite-rules to `.golangci.yml` for code formatting consistency. - Update deprecation comment in `gpage.go` to specify removal in version 3.0.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the linting configuration and updates package deprecation notices. It adds comprehensive gofmt rewrite-rules to modernize Go code patterns and provides clearer deprecation timelines.
Key changes:
- Added extensive gofmt rewrite-rules for modernizing Go patterns (interface{} to any, deprecated ioutil functions)
- Updated deprecation notice to specify removal timeline for version 3.0
- Enhanced GitHub Actions workflow to fetch full git history for linting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .golangci.yml | Added gofmt rewrite-rules for modern Go patterns and deprecated function replacements |
| util/gpage/gpage.go | Updated deprecation comment to specify removal in version 3.0 |
| .github/workflows/golangci-lint.yml | Added fetch-depth: 0 to checkout action for complete git history |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
hailaz
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofmtrewrite-rules to.golangci.ymlfor code formatting consistency.gpage.goto specify removal in version 3.0.