fix(os/gcron): unit testing case of package gcron occasionally failed#4419
Merged
hailaz merged 7 commits intogogf:masterfrom Oct 15, 2025
Merged
fix(os/gcron): unit testing case of package gcron occasionally failed#4419hailaz merged 7 commits intogogf:masterfrom
hailaz merged 7 commits intogogf:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unit test failures in the gcron package that were occurring due to data race conditions. The main purpose is to address concurrency issues that were causing occasional test failures.
Key changes include:
- Added thread-safe access to the logger field with RWMutex protection
- Implemented proper synchronization for the jobWaiter to prevent race conditions
- Added a new non-blocking graceful shutdown method (
StopGracefullyNonBlocking)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
os/gcron/gcron_cron.go |
Added mutex protection for logger field and running state; implemented non-blocking graceful shutdown |
os/gcron/gcron_entry.go |
Added proper synchronization checks before adding to jobWaiter |
os/gcron/gcron.go |
Added wrapper function for new non-blocking graceful shutdown method |
os/gcron/gcron_z_unit_test.go |
Modified tests to use goroutines and added proper cleanup with defer statements |
os/gcron/gcron_z_unit_entry_test.go |
Wrapped cron job additions in goroutines for thread safety testing |
os/gcron/gcron_z_example_1_test.go |
Added new example and updated job names to avoid conflicts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
hailaz
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3999